Add Shadow Services #140

francescomessina · 2019-06-05T12:43:59Z

This PR adds the shadow mode on the cubes.
It adds span mode (only for shadow cubes).
It extends the pcn-router to manage netlink notifications
and take advantage of the shadow mode

mauriciovasquezbernal

I added some general comments about the code.

Main worries are about span mode, I think we re wasting too mush resources for this support.
There is an additional perf ring buffer and thread for each cube, there are also additional lookups in the configuration map, I think it can be a good idea to try to implement this based on the conditional compilation.

src/polycubed/src/cube.cpp

src/libs/polycube/include/polycube/services/cube.h

src/polycubed/src/cube.cpp

src/polycubed/src/cube_tc.cpp

src/polycubed/src/cube_tc.h

src/polycubed/src/cube.cpp

src/services/pcn-router/src/Ports.cpp

src/services/pcn-router/src/UtilityMethods.cpp

francescomessina · 2019-06-06T18:33:46Z

@mauriciovasquezbernal yes, I know, span mode consumes a lot of resources you're right, but I wouldn't know how to improve it, maybe the conditional compilation con help us.

src/libs/polycube/src/utils.cpp

src/polycubed/src/cube.cpp

src/polycubed/src/cube_tc.cpp

src/services/pcn-router/src/Router.cpp

frisso · 2019-06-07T08:39:19Z

Francesco, still missing a little bit of documentation. We should integrate at least the concept of "shadow" service in the documentation: what it is, and what it does.
For the time being, I would avoid documenting explicitly the "span" flag. This should be mentioned, however, in a special section like "Debugging and tracing packets in Polycube services". In there, we can mention this new feature, which is very useful indeed.

mauriciovasquezbernal · 2019-06-07T11:56:45Z

@mauriciovasquezbernal yes, I know, span mode consumes a lot of resources you're right, but I wouldn't know how to improve it, maybe the conditional compilation con help us.

Yes, please use conditional compilation. You can remove the map with the span flag and do a compilation time check with a #if, the logic should almost be the same. The only thing you need to add is that the cube is reloaded when the span mode changes.

- shadow = defines if the service is visible in Linux - span = defines if all traffic is sent to Linux (valid only for shadow services) Signed-off-by: francescomessina <francescomessina92@hotmail.com>

This commit adds a method to get the prefix from netmask, and the one to get the netmask from the prefix. Signed-off-by: francescomessina <francescomessina92@hotmail.com>

Signed-off-by: francescomessina <francescomessina92@hotmail.com>

mauriciovasquezbernal

I tested it, many of the features are working as expected:

namespace and ports are created when a service is in shadow mode
IPs in the polycube instance and in the namespace are updated accordingly
span mode allows to use wireshark, even in other services as bridge

There are some details to be considered:

there is not check for shadow when enabling span mode
I think the documentation has to be extended, why are these services neeed?, Me, as a user, when should use a shadow service?
is this possible to add automatic tests for some features?
-- check if the namespace is created
-- check if ip addresses are updated
-- check if the routing table is updated
-- something more?

src/polycubed/src/cube_tc.cpp

src/polycubed/src/cube.cpp

src/services/pcn-router/test/test_shadow/test1.sh

src/services/pcn-router/test/test_shadow/test2.sh

Signed-off-by: francescomessina <francescomessina92@hotmail.com>

src/polycubed/src/cube.cpp

This commit introduces the following points: - create a namespace for each new shadow service - create a veth and configure the its parameters (if available) - creates a second "hidden" port for each new port created on the shadow service and connects it to the veth - manages incoming traffic on the second port (traffic generated by the namespace) and forwards it out - defines the method "pcn_pkt_redirect_ns()" useful to developers to send the packets to the namespace - handles the Span mode directly in the cube_tc class (only if active) Signed-off-by: francescomessina <francescomessina92@hotmail.com>

This commit register a Shadow router to the netlink events and implements the functions to handle netlink notifications - Route added to the namespace - Route removed from the namespace - Interface removed - New Address on the interface Local traffic and ARP traffic of a Shadow router is managed by the namespace. The setIP, setNetmask and setMac methods have been implemented on the router. Signed-off-by: francescomessina <francescomessina92@hotmail.com>

Signed-off-by: francescomessina <francescomessina92@hotmail.com>

mauriciovasquezbernal

LGTM. Thanks Francesco.

francescomessina requested a review from a team as a code owner June 5, 2019 12:43

mauriciovasquezbernal reviewed Jun 6, 2019

View reviewed changes

frisso requested changes Jun 7, 2019

View reviewed changes

francescomessina force-pushed the shadow_mode branch 2 times, most recently from b38b921 to cecc5ec Compare June 11, 2019 16:10

acloudiator added the under-review label Jun 11, 2019

acloudiator added this to the Polycube Core milestone Jun 11, 2019

francescomessina force-pushed the shadow_mode branch 4 times, most recently from d91c131 to 61aa015 Compare June 17, 2019 15:03

francescomessina added 5 commits June 17, 2019 17:05

Added attributes: "shadow" and "span" to the standard base datamodel.

cbe9b8b

- shadow = defines if the service is visible in Linux - span = defines if all traffic is sent to Linux (valid only for shadow services) Signed-off-by: francescomessina <francescomessina92@hotmail.com>

Add 2 methods to utils:

840f0f8

This commit adds a method to get the prefix from netmask, and the one to get the netmask from the prefix. Signed-off-by: francescomessina <francescomessina92@hotmail.com>

Fix a bug on the veth library (missing a check).

47992c8

Signed-off-by: francescomessina <francescomessina92@hotmail.com>

Add support for ipv6

4c2b43f

Signed-off-by: francescomessina <francescomessina92@hotmail.com>

Add method to send packets to the namespace from the slowpath

c185ed3

Signed-off-by: francescomessina <francescomessina92@hotmail.com>

francescomessina force-pushed the shadow_mode branch from 61aa015 to c8d1d27 Compare June 17, 2019 15:06

mauriciovasquezbernal suggested changes Jun 17, 2019

View reviewed changes

francescomessina added 2 commits June 18, 2019 13:42

Add netlink functions to delete Ip address

533bb17

Signed-off-by: francescomessina <francescomessina92@hotmail.com>

Add new method to set nsid on namespaces

0ffebeb

Signed-off-by: francescomessina <francescomessina92@hotmail.com>

francescomessina force-pushed the shadow_mode branch 2 times, most recently from f769ac5 to 539f5e8 Compare June 18, 2019 13:24

mauriciovasquezbernal reviewed Jun 18, 2019

View reviewed changes

src/polycubed/src/cube.cpp Outdated Show resolved Hide resolved

francescomessina added 2 commits June 19, 2019 10:44

francescomessina added 2 commits June 19, 2019 10:46

Add test Shadow Router

66fb5d7

Signed-off-by: francescomessina <francescomessina92@hotmail.com>

Add the Shadow + Span documentation

ca8f301

Signed-off-by: francescomessina <francescomessina92@hotmail.com>

francescomessina force-pushed the shadow_mode branch from 539f5e8 to ca8f301 Compare June 19, 2019 08:47

mauriciovasquezbernal approved these changes Jun 19, 2019

View reviewed changes

frisso approved these changes Jun 20, 2019

View reviewed changes

frisso merged commit 2692c3f into polycube-network:master Jun 20, 2019

mauriciovasquezbernal mentioned this pull request Jun 27, 2019

Add "mirror port" to debug packet flow #28

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Shadow Services #140

Add Shadow Services #140

francescomessina commented Jun 5, 2019

mauriciovasquezbernal left a comment

francescomessina commented Jun 6, 2019 •

edited

Loading

frisso commented Jun 7, 2019

mauriciovasquezbernal commented Jun 7, 2019

mauriciovasquezbernal left a comment •

edited

Loading

mauriciovasquezbernal left a comment

Add Shadow Services #140

Add Shadow Services #140

Conversation

francescomessina commented Jun 5, 2019

mauriciovasquezbernal left a comment

Choose a reason for hiding this comment

francescomessina commented Jun 6, 2019 • edited Loading

frisso commented Jun 7, 2019

mauriciovasquezbernal commented Jun 7, 2019

mauriciovasquezbernal left a comment • edited Loading

Choose a reason for hiding this comment

mauriciovasquezbernal left a comment

Choose a reason for hiding this comment

francescomessina commented Jun 6, 2019 •

edited

Loading

mauriciovasquezbernal left a comment •

edited

Loading