Fixing jenkinsfile for new k8s slaves #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frisso
approved these changes
Oct 29, 2019
CI/JenkinsfileTestCleanInstance
Outdated
| docker cp polycubed:/usr/local/bin/polycubectl ./bin/ | ||
| docker run -d --name \$container --rm --privileged --pid=host --cap-add ALL --network host -v /proc:/host/proc -v /lib/modules:/lib/modules:ro -v /var/run/netns/:/var/run/netns:rw -v /usr/src:/usr/src:ro -v /etc/localtime:/etc/localtime:ro polycubebot/${image_name}-default:${image_tag} | ||
|
|
||
| # Copying binaries |
There was a problem hiding this comment.
Sorry for the silly question: is there any way to define this code ones, such as with a function? It looks we have a lot of duplicated code here.
|
@michelsciortino Two comments.
|
michelsciortino
changed the title
michelsciortino
force-pushed
the
ms-fixing-jenkins-tests
branch
from
280adeb to
56b3445
Compare
…tables & pcn-nat test netcat timeouts
- NEW: CI/extract_from_docker_image.sh script extracts all the binaries, headers and libraries
from docker image to the slave's file-system
- NEW: CI/clean_slave.sh script cleans the slave's file-system deleting all the file extracted by CI/extract_from_docker_image.sh
- Jenkins test stages now run CI/extract_from_docker_image.sh, execute the tests and run CI/clean_slave.sh
- pcn-pbforwarder tests have been modified as they used a wrong grep regex to obtain the mac addresses of the namespaces
'HWaddr \K.*$' -> 'ether \K[a-fA-F0-9:]{17}|[a-fA-F0-9]{12}$'
- all the netcat timeouts have been increased from 2 to 5 seconds in pcn-nat's and pcn-iptables's tests
michelsciortino
force-pushed
the
ms-fixing-jenkins-tests
branch
from
56b3445 to
49cbc4d
Compare
palexster
changed the title
palexster
changed the title
palexster
approved these changes
Nov 7, 2019
|
Hi @michelsciortino, thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been created to fix Jenkins pipeline for new k8s slaves:
CI/extract_from_docker_image.shscript extracts all the binaries, headers and librariesfrom docker image to the slave file-system
CI/clean_slave.shscript cleans the slave's file-system deleting all the file extracted byCI/extract_from_docker_image.shCI/extract_from_docker_image.sh, execute tests and runCI/clean_slave.shpcn-pbforwardertests have been modified as they were using a wrong grep regex to obtain the mac addresses of the namespaces'HWaddr \K.*$'->'ether \K[a-fA-F0-9:]{17}|[a-fA-F0-9]{12}$'netcattimeouts have been increased from 2 to 5 seconds inpcn-nat's andpcn-iptables's testsJenkins pipeline is partially fixed as there is still a failing test of
pcn-iptables(local_test_interfaces1.sh): a new Issue will be opened soon to report this.Clean Instance TestsandSame Instance Testsnow work and can be used as mandatory checks for new PRs.