Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to create zip and tar of Polycube with submodules #314

Merged
merged 3 commits into from
Jul 9, 2020
Merged

Script to create zip and tar of Polycube with submodules #314

merged 3 commits into from
Jul 9, 2020

Conversation

pinoOgni
Copy link
Collaborator

@pinoOgni pinoOgni commented Jul 2, 2020

This PR introduce a script to create an archive (zip and tar) with all the polycube sources, including submodules. It is possible to choose to make an archive from a branch with a version or from a tag and use the tag for the version.

@pinoOgni pinoOgni requested a review from a team as a code owner July 2, 2020 13:36
@frisso
Copy link
Contributor

frisso commented Jul 6, 2020

@pinoOgni This looks really great!
@sebymiano Two comments.

  1. I moved line "git log -1" into an "if/then/else" block, so to avoid this to be executed always. This is useful when you want to compile the sources from the source pack, when you may not have git installed.
  2. I wonder if the 'install' should support one more option, such as "install everything" or "install only binaries". What do you think?

@frisso frisso merged commit a5bbab6 into polycube-network:master Jul 9, 2020
@acloudiator acloudiator added this to the v0.10.0 milestone Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants