Fix code style #61
Merged
Fix code style #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauriciovasquezbernal
requested review from
mbertrone,
acloudiator,
frisso,
goldenrye and
sebymiano
mauriciovasquezbernal
force-pushed
the
pr/fix_style
branch
from
7e1502a to
c086115
Compare
frisso
approved these changes
Feb 8, 2019
mauriciovasquezbernal
force-pushed
the
pr/fix_style
branch
2 times, most recently
from
766de7d to
28b6687
Compare
check-style is a tool that allows to check and fix the code style. Signed-off-by: Mauricio Vasquez B <mauriciovasquezbernal@gmail.com>
./scripts/check-style.py --fix fix the code style for all revelant files, files in other libraries, like bcc, spdlog and viface are ignored, the same for generated files that should not be modified by the user: - src/services/*/src/api - src/services/*/src/default-src - src/services/*/src/interface - src/services/*/src/serializer Signed-off-by: Mauricio Vasquez B <mauriciovasquezbernal@gmail.com>
mauriciovasquezbernal
force-pushed
the
pr/fix_style
branch
from
28b6687 to
b888d8c
Compare
mbertrone
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a tool to (scripts/check-style.py) check/fix the code style and then run it to fix the code style of the whole project. Datapath code style was also fixed as #55 prevented potential problems with
pcn_log. Automatic code generated that is not intended to be touched by the user is ignored by the script.This is a quite invasive change but I think this is better to do now, after it all PRs must have the code style right.