Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polycubectl: fix help for services #92

Merged
merged 1 commit into from
Mar 28, 2019
Merged

polycubectl: fix help for services #92

merged 1 commit into from
Mar 28, 2019

Conversation

mauriciovasquezbernal
Copy link
Contributor

fix for #88.

@mauriciovasquezbernal
polycubectl: fix help for services
f1d364f 
The parameters required to add a services have changed.

Fixes: d8d280c ("Added new REST API and validation code")

Signed-off-by: Mauricio Vasquez B <mauriciovasquezbernal@gmail.com>
@mauriciovasquezbernal mauriciovasquezbernal requested a review from a team as a code owner March 27, 2019 20:01
@mauriciovasquezbernal mauriciovasquezbernal mentioned this pull request Mar 27, 2019
Closed
mbertrone
mbertrone approved these changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@mbertrone mbertrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I confirm it fixes the issue for me.

@frisso frisso merged commit d9025ee into master Mar 28, 2019
@frisso frisso deleted the pr/fix_service_help branch March 28, 2019 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbertrone mbertrone mbertrone approved these changes

@frisso frisso frisso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mauriciovasquezbernal @frisso @mbertrone