Update Gems and remove R.swift #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 5, 2019
| let alert = UIAlertController(title: R.string.localizable.errorTitle(), message: message, preferredStyle: .alert) | ||
| alert.addAction(UIAlertAction(title: R.string.localizable.ok(), style: .default) { [weak self] _ in | ||
| let message = NSLocalizedString("video-error", comment: "") + "\n" + NSLocalizedString("contact-info", comment: "") | ||
| let alert = UIAlertController(title: NSLocalizedString("error-title", comment: ""), message: message, preferredStyle: .alert) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 131 characters (line_length)
| let message = R.string.localizable.videoError() + "\n" + R.string.localizable.contactInfo() | ||
| let alert = UIAlertController(title: R.string.localizable.errorTitle(), message: message, preferredStyle: .alert) | ||
| alert.addAction(UIAlertAction(title: R.string.localizable.ok(), style: .default) { [weak self] _ in | ||
| let message = NSLocalizedString("video-error", comment: "") + "\n" + NSLocalizedString("contact-info", comment: "") |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 121 characters (line_length)
bcylin
force-pushed
the
feature/remove-rswift
branch
2 times, most recently
from
6edb6ee to
01569e7
Compare
Codecov Report
@@ Coverage Diff @@
## develop #8 +/- ##
============================================
- Coverage 40.74% 17.37% -23.38%
============================================
Files 49 43 -6
Lines 1885 1370 -515
Branches 28 0 -28
============================================
- Hits 768 238 -530
- Misses 1114 1132 +18
+ Partials 3 0 -3
Continue to review full report at Codecov.
|
bcylin
force-pushed
the
feature/remove-rswift
branch
from
01569e7 to
fdd1b38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to be very difficult to migrate the project from Swift 3 to Swift 5 at once. One possible approach is to reduce third party dependencies and update different parts of the project separately.
This PR updates the Gems and removes the dependency of R.swift, which caused a problem in some versions of Xcode and CocoaPods.
TBD: