Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use peg/replace-all over string/replace-all where possible #331

Closed
Tracked by #328
MichalMarsalek opened this issue Dec 29, 2023 · 1 comment · Fixed by #337
Closed
Tracked by #328

Use peg/replace-all over string/replace-all where possible #331

MichalMarsalek opened this issue Dec 29, 2023 · 1 comment · Fixed by #337

Comments

@MichalMarsalek
Copy link
Collaborator

No description provided.

@MichalMarsalek MichalMarsalek mentioned this issue Dec 29, 2023
Open
6 tasks
@MeWhenI
Copy link
Contributor

MeWhenI commented Dec 30, 2023 •
edited
Loading

After reading up on Janet docs, it looks like I misunderstood the difference between the two functions, it seems peg/replace-all can always be used for the same functionality as string/replace-all when the first arg is a string.

MeWhenI added a commit to MeWhenI/polygolf that referenced this issue Dec 30, 2023
@MeWhenI
Complete polygolf-lang#331
ca19baa
@MichalMarsalek MichalMarsalek mentioned this issue Dec 30, 2023
Merged
MichalMarsalek pushed a commit that referenced this issue Dec 30, 2023
@MeWhenI
Complete #331 (#337)
1b38dbb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Complete #331 MeWhenI/polygolf
2 participants
@MichalMarsalek @MeWhenI