-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update rest snapshot models, add FMV data types and new feed urls for websockets #356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to update the websocket spec too?
yeah i believe @aliche-a has a PR for the ws specs update somewhere? I think we're waiting to release that |
@aitzkovitz hmm i don't a PR or commit with the updated ws spec |
Hmm i was looking at this issue and saw that it was reference by another issue titled [WIP] Update Launchpad Websocket specs #332. But that link is broken, so maybe that work hasn't ben done yet. Do you think this PR depends on that work? |
@aitzkovitz yeah if you're updating the websocket client, you should update the spec too, it's just a simple command in the makefile |
Oh i see what you're saying. I ran both the
Oh i see what you're saying. I ran both the websocket and rest spec update commands originally. But we haven't released any spec changes (we're waiting until next week) so those should look the same aside from any other spec changes which have gone out since the last release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aitzkovitz got it, lgtm!
This PR is the one I had to update ws specs, but I made it before we decided not to modify the existing Launchpad @aitzkovitz I think we also need to update this handleData method so FMV data can be unmarshalled into the FMV model. |
cd80a6b
to
af8b909
Compare
…client-go into ai.support-business-products
… websockets (polygon-io#356) Co-authored-by: GitHub Action <action@github.com>
No description provided.