Sort Parameter Missing From Aggregates (Bars) #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @noah-hein, thanks very much for the PR that adds the sort param, updating the examples, and the spec too. What a great PR! Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using the API I noticed the sort field is missing from the Aggregate (Bars) parameters.
Added in the missing parameter to the Aggregate.kt file and made sure it was placed as a URL parameter.
This was a very simple few lines modified. If I missed any test cases or samples please let me know.
Screenshot of the official documentation showcasing the sort parameter
Screenshot of the decompiled Kotlin file for the current version missing the parameter
