Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-category skip modes & Unskip support #5

Merged
merged 2 commits into from
Jan 27, 2024

Conversation

mikooomich
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Hi. I have been brutally stabbed too many times to count by CheckStyle. In my dying breaths... I bring you per-category skip settings and "un-skipping" of segments.

  • When within a segment, added an option to manually skip. This is controlled by "Show manual buttons"
  • Added ability to un-skip auto skipped segments for 5 seconds after the segment elapses
  • Added a toggle to allow "rewinding" into segments (ex. double tap to re-watch skipped segment will actually allow you to watch the segment). This is controlled via "Rewind pauses skipping"
  • Per-segment category skip options (Automatic, manual, highlight only). This is controlled by "Skip Mode" from within SponsorBlock Categories

Before/After Screenshots/Screen Record

  • After:
    tubular_demo

Settings

The default settings are:

  • Show manual buttons : on
  • Rewind pauses skipping: on
  • SponsorBlock Categories: Skip Mode defaults to "Automatic", a.k.a mimicing the existing behavour of the Enable toggle

Extra notes

  • Tested on Android 14 (LineageOS 21)
  • Buttons may be offset weirdly when rotating the device.
    • I am pretty sure is an upstream issue (the underlying view/container does that)
  • Why are you creating a whole new button for an icon when you can replace it all with:
    • app:drawableLeftCompat="@drawable/ic_previous" android:drawableTint="@color/white"
    • SDK drawableTint requires SDK 23 (we are on 21)
  • Possibility of not vertically centered skip/un-skip buttons, they are however aligned with the play button... which I just found out also isn't centered

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@polymorphicshade polymorphicshade merged commit 2f8e863 into polymorphicshade:master Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants