Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UI more responsive #15

Closed
wants to merge 4 commits into from
Closed

Conversation

erdengk
Copy link

@erdengk erdengk commented Dec 16, 2021

This PR is used to solve the display bug it mentioned.
Before modification:
WX20211214-214526

After modification:
WX20211216-091202
WX20211216-091236

@vogti
Copy link
Member

vogti commented Dec 19, 2021

Hi Kevin,
Thanks for this pull request. Unfortunately, your fix does only work for your specific monitor resolution:
Bildschirmfoto 2021-12-19 um 22 50 39
Can you make this more universal?

@erdengk
Copy link
Author

erdengk commented Dec 20, 2021

OK, I'll try again

@erdengk
Copy link
Author

erdengk commented Dec 20, 2021

@vogti
Hello, I used a new way to fix this bug. Please review it. Thanks.

In the figure below, the browser window is zoomed to the minimum The foot bar is not blocked or in the wrong place.
WX20211220-203557@2x

In the figure below, the browser window is zoomed to medium The foot bar is not blocked or in the wrong place.
WX20211220-203707@2x

In the figure below, the browser window is zoomed to the maximum The foot bar is not blocked or in the wrong place
WX20211220-204124@2x

@vogti
Copy link
Member

vogti commented Dec 20, 2021

But now it is no longer centered if the window exceeds a certain width. Furthermore, the footer is only visible if you scroll.
Bildschirmfoto 2021-12-20 um 15 37 26

I think to fix this, it is required to calculate a max-height for the white box. Since everything is dynamic, this part needs to be dynamic as well.

@erdengk
Copy link
Author

erdengk commented Dec 21, 2021

OK, I'll try to repair it again.

@erdengk
Copy link
Author

erdengk commented Dec 21, 2021

Hello, I made a new modification according to your opinion.Please review it. Thanks.
The latest effect is shown in the following figures. No matter how you change the window size, the middle box is always in the middle, and you can see the footer without scrolling.

WX20211221-184136

image

About the problem you mentioned that when the maximum width is exceeded, it cannot be centered.
I use such a solution:
In the following figure, when the window becomes larger, the button in the middle will be enlarged to the same scale and will always be in the middle.

WX20211221-183559

In the following figure, when the window width becomes large, the middle button will always be enlarged, but a navigation bar will be generated on the right side of the browser to allow users to browse down.
By the way, I modified the styles of PDB and Pui in footer so that they will not exceed the footer due to window changes.

WX20211221-184358

@erdengk
Copy link
Author

erdengk commented Jan 8, 2022

Hi, @vogti Maybe my method is not very good, but I am willing to continue to learn and improve it. Please give some suggestions. Thanks

@vogti
Copy link
Member

vogti commented Jan 10, 2022

Hi @erdengk
Sorry for the late replay. There has been a lot going on since new year. Your new approach looks much better. However, it does no longer resolve the issue you have pointed out initially.

Bildschirmfoto 2022-01-10 um 12 20 21

@erdengk
Copy link
Author

erdengk commented Jan 10, 2022

Oh, my God. Let me try to continue to fix this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants