GIS #462: moved default mapping from Geometry to Text to SqlDialect

polypheny · Dec 10, 2023 · a389260 · a389260
1 parent f9a9802
commit a389260
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 9 deletions.
diff --git a/...stgres-adapter/src/main/java/org/polypheny/db/adapter/postgres/store/PostgresqlStore.java b/...stgres-adapter/src/main/java/org/polypheny/db/adapter/postgres/store/PostgresqlStore.java
@@ -372,6 +372,7 @@ protected String getTypeString( PolyType type ) {
                 return "DECIMAL";
             case VARCHAR:
                 return "VARCHAR";
+            case GEOMETRY:
             case JSON:
                 return "TEXT";
             case DATE:

diff --git a/plugins/sql-language/src/main/java/org/polypheny/db/sql/language/SqlDialect.java b/plugins/sql-language/src/main/java/org/polypheny/db/sql/language/SqlDialect.java
@@ -19,6 +19,7 @@
 
 import com.google.common.base.Preconditions;
 import com.google.common.base.Suppliers;
+import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableSet;
 import java.sql.ResultSet;
 import java.sql.Timestamp;
@@ -572,11 +573,7 @@ public CalendarPolicy getCalendarPolicy() {
     public SqlNode getCastSpec( AlgDataType type ) {
         if ( type instanceof BasicPolyType ) {
             int precision = type.getPrecision();
-            if ( type.getPolyType() == PolyType.JSON ) {
-                precision = 2024;
-                type = new PolyTypeFactoryImpl( AlgDataTypeSystem.DEFAULT ).createPolyType( PolyType.VARCHAR, precision );
-            }
-            if ( type.getPolyType() == PolyType.NODE ) {
+            if ( List.of( PolyType.JSON, PolyType.NODE, PolyType.GEOMETRY ).contains( type.getPolyType() ) ) {
                 precision = 2024;
                 type = new PolyTypeFactoryImpl( AlgDataTypeSystem.DEFAULT ).createPolyType( PolyType.VARCHAR, precision );
             }

diff --git a/...ns/sql-language/src/main/java/org/polypheny/db/sql/language/dialect/HsqldbSqlDialect.java b/...ns/sql-language/src/main/java/org/polypheny/db/sql/language/dialect/HsqldbSqlDialect.java
@@ -81,14 +81,14 @@ public SqlNode getCastSpec( AlgDataType type ) {
         String castSpec;
         switch ( type.getPolyType() ) {
             case ARRAY:
-                // We need to flag the type with a underscore to flag the type (the underscore is removed in the unparse method)
+                // We need to flag the type with an underscore to flag the type (the underscore is removed in the unparse method)
                 castSpec = "_LONGVARCHAR";
                 break;
             case FILE:
             case IMAGE:
             case VIDEO:
             case AUDIO:
-                // We need to flag the type with a underscore to flag the type (the underscore is removed in the unparse method)
+                // We need to flag the type with an underscore to flag the type (the underscore is removed in the unparse method)
                 castSpec = "_BLOB";
                 break;
             case INTERVAL_YEAR_MONTH:

diff --git a/...s/sql-language/src/main/java/org/polypheny/db/sql/language/dialect/MonetdbSqlDialect.java b/...s/sql-language/src/main/java/org/polypheny/db/sql/language/dialect/MonetdbSqlDialect.java
@@ -76,14 +76,14 @@ public SqlNode getCastSpec( AlgDataType type ) {
         String castSpec;
         switch ( type.getPolyType() ) {
             case ARRAY:
-                // We need to flag the type with a underscore to flag the type (the underscore is removed in the unparse method)
+                // We need to flag the type with an underscore to flag the type (the underscore is removed in the unparse method)
                 castSpec = "_TEXT";
                 break;
             case FILE:
             case IMAGE:
             case VIDEO:
             case AUDIO:
-                // We need to flag the type with a underscore to flag the type (the underscore is removed in the unparse method)
+                // We need to flag the type with an underscore to flag the type (the underscore is removed in the unparse method)
                 castSpec = "_BLOB";
                 break;
             default: