Additional Connection Method for File-based Sources #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… authentication logic
…to source-file-handling
datomo
changed the title
vogti
changed the title
vogti
approved these changes
Mar 14, 2023
vogti
changed the title
vogti
pushed a commit
that referenced
this pull request
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires the following UI PR: #80
Summary
This PR introduces a new connection method, which allows to not only upload but also link to source files of the Excel and CSV-sources. For this the user is requested to place a
polypheny.accessfile in the location, in which the source file resides.This is due to security limitations of the webbrowser and should prohibit the user from entering a folder to which they do not have access rights.
Additionally, it also adds the ability for conditional
AdapterSettings, which allows to define a parent for a setting, with a specific value. Due to limitations of Annotations in Java this is done on string basis.Changes
LinkingFeatures
subOfvariable to allAdapterSettings, which allows to specify a parent