-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock the Polypheny Home Directory #501
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This unwrap will be empty when the type of the entity is not a collection. Example: db.emps.insertOne({"name": "Alice"})
Expanding views is done further up.
vogti
force-pushed
the
various-improvements
branch
from
July 28, 2024 11:09
2001d52
to
2b78798
Compare
datomo
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good for me. Thx @gartens.
vogti
force-pushed
the
various-improvements
branch
from
August 5, 2024 20:04
4ac3385
to
ecefed3
Compare
vogti
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, @gartens, for this PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Until now Polypheny used the port 7659 to determine if another instance is running and would then refuse to start. This approach fails to detect instances using other ports. This is especially a problem, if one of these instances were to use the same home directory. So to prevent this, create a
.lock
file in the home directory and lock it using facilities provided by the operating system. This way each home directory can only be used by one instance at a time.There are also various other small improvements.
There is also a corresponding UI PR because a field is renamed.