-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Textual and Visual Algebra Exploration #503
Open
tobias-weber
wants to merge
133
commits into
master
Choose a base branch
from
algebra-exploration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+9,904
−1,102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ary substitution for documents to improve performance
…rom ddlManager and catalog methods
gartens
reviewed
Aug 14, 2024
gartens
reviewed
Aug 14, 2024
gartens
reviewed
Aug 14, 2024
…to algebra-exploration
…ing null error for polyAlg tests
…ded handling for concurrent delays for testing
datomo
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This look good to me (except the sometimes single failing tests...)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances Polypheny with the ability to serialize arbitrary query plans into a textual representation called PolyAlgebra. This is the foundation for the new framework-based plan editor system in the UI. The required functionality is provided via new HTTP endpoints and websocket messages.
Changes
Removed the old query plan builder
Replaced the old InformationQueryPlan with InformationPolyAlg for the new plan editor
Changed the order of information pages for executed queries to be grouped by statements
Added
Optional
for multiple cost and count metadata @datomoChanged
CyclicMetadataException
to followGenericRuntimeException
@datomoFeatures
Tests
ToDo
CYPHER_EXTRACT_FROM_PATH
, then enable corresponding tests inPolyAlgParsingTest
bindArguments()
and staticcreate()
method). This can also be done at a later point, as it is only required for the rare use case of editing physical plans.