Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no default constructor #3

Merged
merged 2 commits into from
Oct 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
name: Foundry CI

on:
push:
branches:
- main
pull_request:
branches:
- main

concurrency:
group: ${{ github.ref }}
cancel-in-progress: true

env:
FOUNDRY_PROFILE: ci

jobs:
check-solidity:
strategy:
fail-fast: true

name: Foundry project
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
submodules: recursive

- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
with:
version: nightly

- name: Run Forge build
run: |
forge --version
forge build --sizes
id: build

- name: Run Forge tests
run: |
forge test -vvv
id: test
2 changes: 1 addition & 1 deletion src/tokens/ERC20.sol
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ contract MultiChainNativeERC20 is ERC165Storage, ERC20, IERC6160Ext20 {
/// @notice mapping of admins of defined roles
mapping(bytes32 => mapping(address => bool)) _rolesAdmin;

constructor() ERC20("Multi Chain Native ERC20 TOken", "MCNT") {
constructor(string memory name, string memory symbol) ERC20(name, symbol) {
_registerInterface(_IERC6160Ext20_ID_);
_registerInterface(type(IERC5679Ext20).interfaceId);
_registerInterface(type(IERC_ACL_CORE).interfaceId);
Expand Down
2 changes: 1 addition & 1 deletion test/ERC20.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ contract ERC20Test is Test {
bytes32 constant BURNER_ROLE = keccak256("BURNER ROLE");

function setUp() public {
token = new MultiChainNativeERC20();
token = new MultiChainNativeERC20("Multi Chain Native ERC20 TOken", "MCNT");
}

function testNameSymbol() public {
Expand Down