Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patricia trie decoding #41

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

jstinhw
Copy link
Contributor

@jstinhw jstinhw commented Mar 20, 2024

Solve #40

  1. Ensure that the leading shared nibble is retained with odd number of shared nibbles.
  2. Involves adjusting the slicing mechanism to account for the original offset of keyNibbles.

@seunlanlege
Copy link
Member

I didn't implement the ethereum trie verifier, so i can't comment on if this fix is correct or not. But i'll tag the original author @ripa1995 to get his thoughts

@ripa1995
Copy link
Contributor

Sorry for late reply, it was a busy week.
Anyway, LGTM
Just one minor comment, I would move the test you've added from test/MerklePatricia.t.sol to integration-tests/src/merkle_patricia.rs.

@seunlanlege, looks like integration tests are not run as part of the GHA, is that intentional?

@seunlanlege
Copy link
Member

Sorry for late reply, it was a busy week.

Anyway, LGTM

Just one minor comment, I would move the test you've added from test/MerklePatricia.t.sol to integration-tests/src/merkle_patricia.rs.

@seunlanlege, looks like integration tests are not run as part of the GHA, is that intentional?

Yeah they're broken atm on CI haven't had the time to bring them back.

@seunlanlege seunlanlege merged commit 2af5d06 into polytope-labs:main Mar 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants