Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve plugin development experience #620

Merged
merged 31 commits into from
Apr 21, 2022
Merged

feat: improve plugin development experience #620

merged 31 commits into from
Apr 21, 2022

Conversation

Niraj-Kamdar
Copy link
Contributor

@Niraj-Kamdar Niraj-Kamdar commented Jan 24, 2022 •
edited
Loading

This PR implements new Plugin dev exp spec as discussed in the above issue.

Open questions:

  • Should we rename loadEnv -> setEnv ?
  • Should we move name from metaManifest to Manifest ( for both Plugin and Wasm) ?

@Niraj-Kamdar Niraj-Kamdar marked this pull request as draft January 24, 2022 17:11
@Niraj-Kamdar
feat: make meta manifest optional for plugins
dc51d4f 
- generates random name for plugin if meta manifest not defined
- Improve bindgen process
@Niraj-Kamdar
lint fixes and few changes
6dd6165
@dOrgJelli dOrgJelli mentioned this pull request Jan 25, 2022
Closed
@Niraj-Kamdar Niraj-Kamdar marked this pull request as ready for review January 26, 2022 07:44
nerfZael
nerfZael requested changes Jan 26, 2022
View reviewed changes
packages/cli/src/__tests__/plugin/expected-schema/schema.graphql Outdated Show resolved Hide resolved
packages/js/client/src/plugin/PluginWeb3Api.ts Outdated Show resolved Hide resolved
packages/js/plugins/ethereum/web3api.plugin.yaml Outdated Show resolved Hide resolved
packages/js/plugins/ethereum/schema.graphql Outdated Show resolved Hide resolved
packages/schema/bind/src/bindings/plugin-ts/createPluginContext.ts Outdated Show resolved Hide resolved
packages/js/core/src/algorithms/index.ts Outdated Show resolved Hide resolved
@Niraj-Kamdar Niraj-Kamdar changed the base branch from prealpha to prealpha-dev February 1, 2022 06:44
@dOrgJelli dOrgJelli mentioned this pull request Mar 22, 2022
Closed
3 tasks
@dOrgJelli dOrgJelli mentioned this pull request Mar 30, 2022
Open
@nerfZael nerfZael mentioned this pull request Apr 12, 2022
Closed
@dOrgJelli dOrgJelli merged commit ba8ff13 into prealpha-dev Apr 21, 2022
@dOrgJelli dOrgJelli mentioned this pull request Apr 21, 2022
Merged
@dOrgJelli dOrgJelli deleted the nk/plugin-modules branch February 2, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dOrgJelli dOrgJelli dOrgJelli approved these changes

@nerfZael nerfZael Awaiting requested review from nerfZael nerfZael is a code owner

@namesty namesty Awaiting requested review from namesty namesty is a code owner

@krisbitney krisbitney Awaiting requested review from krisbitney

@ramilexe ramilexe Awaiting requested review from ramilexe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin should have module-wise resolvers similar to the wasm
3 participants
@Niraj-Kamdar @dOrgJelli @nerfZael