Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build-env image overwriting #678

Merged
merged 7 commits into from
Feb 13, 2022
Merged

Conversation

namesty
Copy link
Collaborator

@namesty namesty commented Feb 11, 2022

Closes #616

Only in the case where the user builds 2 wrappers without specifying a build manifest in any of them, would the image overwriting happen. However, if the manifest's declared language changed, we would need to reconstruct the build/env cache directory; else the directory should be reused (so that the uuid does not change between builds of the same project). Therefore, the implementation is:

  1. Cache web3api.yaml to cache the language with which the cache build/env dir was created
  2. Stop reconstructing the cache build/env dir each time the project builds
  3. If language did not change or no previous build/env is found in the cache dir, then copy default env files, adding the uuid suffix to the image name.

@namesty namesty changed the title 616 build image overwrite Build-env image overwriting Feb 11, 2022
@namesty namesty changed the base branch from prealpha to prealpha-dev February 11, 2022 05:11
@dOrgJelli dOrgJelli merged commit 969da6d into prealpha-dev Feb 13, 2022
@dOrgJelli dOrgJelli deleted the 616-build-image-overwrite branch February 2, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build-Time Improvement: Don't Overwrite Build Image Cache
2 participants