Use Result type and throw fewer errors in Client and Core #1277
Conversation
…nt-core # Conflicts: # packages/js/test-env/src/index.ts
krisbitney
requested review from
dOrgJelli,
nerfZael,
ramilexe,
namesty and
Niraj-Kamdar
as code owners
|
This pull request fixes 1 alert when merging 86caf5a into 3cb0263 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging ca10282 into 3cb0263 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging fa6c52d into 3cb0263 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 657b2da into 3bf6502 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 6ab5736 into 3bf6502 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging ae28dc1 into 3bf6502 - view on LGTM.com fixed alerts:
|
| @@ -202,7 +215,7 @@ export class PolywrapClient implements Client { | |||
| >(options: QueryOptions<TVariables, TUri>): Promise<QueryResult<TData>> { | |||
| let result: QueryResult<TData>; | |||
|
|
|||
| try { | |||
| err: try { | |||
There was a problem hiding this comment.
Just curious here: What's the reason for this syntax? I am noticing that you are then using a break but we can also return { errors: [parseResult.error as Error] }? Probably I am wrong but just wanted to understand this :P
There was a problem hiding this comment.
It's because of the clearContext below the try catch statement. I wanted to be sure it still ran since it was running on error before the changes.
| expect(response.data).toBeDefined(); | ||
| expect(response.data).toBe(true); | ||
| if (!response.ok) fail(response.error); | ||
| expect(response.value).toBeDefined(); |
There was a problem hiding this comment.
I think this one is redundant
|
@krisbitney PR looks awesome! I left a couple comments and there's some minor fixes in this PR: #1285 |
…-fixes Result error handling fixes
|
This pull request fixes 1 alert when merging af0d730 into 3bf6502 - view on LGTM.com fixed alerts:
|
This PR replaces most thrown errors in the client and core with the
Resultpattern. Notably,client.invokenow returns aResult<TData, Error>.Closes #1018, #1245