Fix: correctly handle error in getImplementations algorithm #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rray in get-implementations.ts
krisbitney
requested review from
dOrgJelli,
nerfZael,
ramilexe,
namesty and
Niraj-Kamdar
as code owners
|
This pull request fixes 1 alert when merging 454d27d into b95c714 - view on LGTM.com fixed alerts:
|
nerfZael
requested changes
Sep 28, 2022
nerfZael
reviewed
Sep 29, 2022
…<true, Error> to Result<undefined, Error>
nerfZael
approved these changes
Sep 30, 2022
cbrzn
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts an accidentally change to the behavior of getImplementations in #1277, where an error that was previous thrown instead became ignored