Merge pull request #1288 from polywrap/throw-in-get-implementations

Fix: correctly handle error in getImplementations algorithm
polywrap · Oct 5, 2022 · 30f7f64 · 30f7f64
2 parents 6436804 + df20049
commit 30f7f64
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/packages/js/core/src/algorithms/get-implementations.ts b/packages/js/core/src/algorithms/get-implementations.ts
@@ -23,7 +23,7 @@ export const getImplementations = Tracer.traceFunc(
     const addAllImplementationsFromImplementationsArray = (
       implementationsArray: readonly InterfaceImplementations<Uri>[],
       wrapperInterfaceUri: Uri
-    ) => {
+    ): Result<undefined, Error> => {
       for (const interfaceImplementations of implementationsArray) {
         let fullyResolvedUri: Uri;
         if (redirects) {
@@ -32,7 +32,7 @@ export const getImplementations = Tracer.traceFunc(
             redirects
           );
           if (!redirectsResult.ok) {
-            continue;
+            return redirectsResult;
           }
           fullyResolvedUri = redirectsResult.value;
         } else {
@@ -45,6 +45,7 @@ export const getImplementations = Tracer.traceFunc(
           }
         }
       }
+      return ResultOk(undefined);
     };
 
     let finalUri = wrapperInterfaceUri;
@@ -57,8 +58,11 @@ export const getImplementations = Tracer.traceFunc(
       finalUri = redirectsResult.value;
     }
 
-    addAllImplementationsFromImplementationsArray(interfaces, finalUri);
+    const addAllImp = addAllImplementationsFromImplementationsArray(
+      interfaces,
+      finalUri
+    );
 
-    return ResultOk(result);
+    return addAllImp.ok ? ResultOk(result) : addAllImp;
   }
 );