polywrap create template command
#1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrzn
reviewed
Feb 8, 2023
packages/cli/src/lib/project/templates/downloadProjectTemplate.ts
Outdated
Show resolved
Hide resolved
dOrgJelli
reviewed
Feb 19, 2023
dOrgJelli
requested changes
Feb 19, 2023
There was a problem hiding this comment.
This is super clean @krisbitney, amazing & quick work. Only thing I'd like to be different is the treatment of the cache directory. Let's quickly make that more uniform and use a user-level cache within the operating system. That way other functionality can make use of it in the future too! (ex: import caching, etc)
packages/cli/src/lib/project/templates/downloadProjectTemplate.ts
Outdated
Show resolved
Hide resolved
…plate-from-url # Conflicts: # packages/cli/src/__tests__/e2e/create.spec.ts # packages/cli/src/commands/create.ts # packages/cli/src/lib/project/templates/index.ts # yarn.lock
…h setup in create.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
templatecommand to the CLI'spolywrap create. Thetemplatecommand lets users provide a url and downloads the template for them.As described in #768 , the initial implementation only supports
.gitURLs. I implemented it with the assumption that additional URL formats will be added now or in the future.Closes #768