-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: --no-codegen option is now recognized in polywrap build
#1618
Conversation
…to `codegen` by Commander package in build command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this merged ASAP, as it also fixes the IPFS hash issue! :D
Full disclosure: I was the one that changed this codegen
stuff, and I left it as such since, with Commander, specifying a --codegen
flag also adds the option of --no-codegen
as an alternative flag. I did exclude the noCodegen
option for the CLI-JS, as I didn't think of it at the time. Good catch @krisbitney!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bravo @cbrzn!
i've (in theory) fixed all tests except for this last test, is failing in this line https://github.com/polywrap/toolchain/blob/kris/fix-codegen-option-recognition/packages/cli/src/lib/project/templates/generateProjectTemplate.ts#L142-L149 and the reason is that we've done a change in I've seen this problem before, but I do not remember what fixed it... Also, it's worth mentioning that this error is totally unrelated to this PR, and it was introduced two weeks ago in this PR #1529 ( i think a hotfix might be to hard code the current version of |
Thank you @krisbitney! Let's fix the |
fix for issue where
noCodegen
option name is automatically changed tocodegen
by Commander package in build command