Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polywrap test now exits with exist code 1 if a test fails #1610

Merged
merged 2 commits into from
Mar 8, 2023
Merged

polywrap test now exits with exist code 1 if a test fails #1610

merged 2 commits into from
Mar 8, 2023

Conversation

krisbitney
Copy link
Contributor

@krisbitney krisbitney commented Mar 7, 2023 •
edited
Loading

Closes #1358

@krisbitney krisbitney requested review from cbrzn and pileks March 7, 2023 18:36
pileks
pileks approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@pileks pileks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dOrgJelli dOrgJelli merged commit f4a4e0b into origin-dev Mar 8, 2023
@dOrgJelli dOrgJelli deleted the kris/test-cmd-nonzero-exit-on-fail branch April 10, 2023 16:55
@dOrgJelli dOrgJelli mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dOrgJelli dOrgJelli dOrgJelli approved these changes

@pileks pileks pileks approved these changes

@namesty namesty Awaiting requested review from namesty namesty is a code owner

@nerfZael nerfZael Awaiting requested review from nerfZael

@Niraj-Kamdar Niraj-Kamdar Awaiting requested review from Niraj-Kamdar

@cbrzn cbrzn Awaiting requested review from cbrzn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI: Run (Test) Command Exits W/O Error When Wrapper Not Found
3 participants
@krisbitney @pileks @dOrgJelli