Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wrap-rust): update with latest polywrap-wasm-rs and use ByteBuf #101

Merged
merged 8 commits into from
Sep 11, 2023

Conversation

cbrzn
Copy link
Contributor

@cbrzn cbrzn commented Sep 4, 2023

once we merge & release polywrap/wrap-cli#1887; we must bump the version, and we will be ready to go

@dOrgJelli dOrgJelli marked this pull request as ready for review September 8, 2023 11:57
Copy link
Contributor

@krisbitney krisbitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Is ByteBuf just a wrapper around Vec<u8> or is it something different?

@cbrzn
Copy link
Contributor Author

cbrzn commented Sep 11, 2023

This looks good to me! Is ByteBuf just a wrapper around Vec<u8> or is it something different?

yah, that's exactly it

@krisbitney
Copy link
Contributor

This looks good to me! Is ByteBuf just a wrapper around Vec<u8> or is it something different?

yah, that's exactly it

Okay, cool, thanks

@cbrzn cbrzn merged commit b94d221 into main Sep 11, 2023
15 checks passed
@cbrzn cbrzn deleted the chore/wrap-rust-with-latest-wasm-rs branch September 11, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants