fix: use generic ArrayBufferView instead of Uint8Array

polywrap · Jun 28, 2022 · 08926c8 · 08926c8
1 parent 021e9cb
commit 08926c8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/js/client/src/plugin/PluginWrapper.ts b/packages/js/client/src/plugin/PluginWrapper.ts
@@ -77,7 +77,7 @@ export class PluginWrapper extends Wrapper {
       await this._sanitizeAndLoadEnv(client, module);
 
       let jsArgs: Record<string, unknown>;
-      if (args instanceof ArrayBuffer || args instanceof Uint8Array) {
+      if (args instanceof ArrayBuffer || ArrayBuffer.isView(args)) {
         const result = msgpackDecode(args);
 
         Tracer.addEvent("msgpack-decoded", result);

diff --git a/packages/js/core/src/types/Invoke.ts b/packages/js/core/src/types/Invoke.ts
@@ -15,7 +15,7 @@ export interface InvokeOptions<
    * Arguments for the method, structured as a map,
    * removing the chance of incorrectly ordering arguments.
    */
-  args?: Record<string, unknown> | Uint8Array | ArrayBuffer;
+  args?: Record<string, unknown> | ArrayBufferView | ArrayBuffer;
 
   /**
    * If set to true, the invoke function will not decode the msgpack results