Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add requestAccounts method to ethereum plugin #1068

Merged
merged 2 commits into from
Jul 28, 2022

Conversation

krisbitney
Copy link
Contributor

@krisbitney krisbitney commented Jul 23, 2022

the requestAccounts method in the ethereum plugin calls "eth_requestAccounts", which is required to initiate metamask.

Closes #1066.

@krisbitney krisbitney linked an issue Jul 23, 2022 that may be closed by this pull request
Niraj-Kamdar
Niraj-Kamdar previously approved these changes Jul 25, 2022
Copy link
Contributor

@Niraj-Kamdar Niraj-Kamdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@cbrzn cbrzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🍏

@cbrzn cbrzn requested a review from Niraj-Kamdar July 27, 2022 15:33
@dOrgJelli dOrgJelli merged commit cc113f6 into origin-dev Jul 28, 2022
@dOrgJelli dOrgJelli deleted the add-request-accounts-to-eth branch April 10, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add eth_requestAccounts function in ethereum plugin
4 participants