feat: add wrapper subinvoke test case #1328
Conversation
Niraj-Kamdar
requested review from
dOrgJelli,
krisbitney,
namesty and
nerfZael
as code owners
| export function add(args: Args_add): i32 { | ||
| let importedArgs: ImportedArgs_add = { | ||
| a: args.a, | ||
| b: args.b | ||
| } | ||
| return Add_Module.add(importedArgs).unwrap() | ||
| } |
There was a problem hiding this comment.
Why this change? I'd prefer to have a different output for invoke and subinvoke. It'll be easy to debug and spot some horrible bugs that would be passed safely due to a buggy client implementation.
There was a problem hiding this comment.
I changed it just to make it work and have a super simple example
I'd prefer to have a different output for invoke and subinvoke
Gotcha, if we just use the add method in the invoke and add 1 to that result, would that be enough for you? Meaning that the invoke method would return the sum of two numbers + 1, and the subinvoke would just return the sum of two numbers
There was a problem hiding this comment.
Yeah, that'd work. You can call it add_and_increament then
|
@dOrgJelli I had requested changes that weren't addressed yet. @cbrzn Can you create a patch PR for this? |
|
@Niraj-Kamdar yah no worries is on my todo list |
No description provided.