Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for polywrap binary artifact upload in CD #1903

Merged
merged 2 commits into from
Sep 13, 2023
Merged

fix for polywrap binary artifact upload in CD #1903

merged 2 commits into from
Sep 13, 2023

Conversation

krisbitney
Copy link
Contributor

No description provided.

dOrgJelli
dOrgJelli previously approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@dOrgJelli dOrgJelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, is it ready to go?

@krisbitney
Copy link
Contributor Author

No, please don't merge this.

@krisbitney krisbitney marked this pull request as draft September 12, 2023 17:23
@krisbitney krisbitney marked this pull request as ready for review September 13, 2023 17:01
@krisbitney
Copy link
Contributor Author

This is ready

dOrgJelli
dOrgJelli approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@dOrgJelli dOrgJelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@dOrgJelli dOrgJelli merged commit 17b4117 into origin-dev Sep 13, 2023
15 checks passed
@dOrgJelli dOrgJelli mentioned this pull request Sep 13, 2023
Merged
@krisbitney krisbitney deleted the kris/fix-release-files branch September 14, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dOrgJelli dOrgJelli dOrgJelli approved these changes

@namesty namesty Awaiting requested review from namesty namesty is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krisbitney @dOrgJelli