Fix: Web assembly async instantiation #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrzn
changed the title
cbrzn
force-pushed
the
fix/asyncify-init-async
branch
from
036dc9e
to
72a41b4
Compare
dOrgJelli
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the WASM files are bigger than 4kb, the main thread will be disallowed (See more here https://stackoverflow.com/questions/45284788/webassembly-compile-is-disallowed-on-the-main-thread-if-the-buffer-size-is-larg?rq=1)
The change on this PR implements the instantiation of the WebAssembly class through an async method, which is
instantiate