Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Issue #561 "LinkError: WebAssembly.Instantiate..." #562

Merged
merged 4 commits into from
Dec 2, 2021
Merged

Fix: Issue #561 "LinkError: WebAssembly.Instantiate..." #562

merged 4 commits into from
Dec 2, 2021

Conversation

dOrgJelli
Copy link
Contributor

closes: #561

@krisbitney krisbitney self-requested a review December 1, 2021 12:48
krisbitney
krisbitney previously approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@krisbitney krisbitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dOrgJelli
Copy link
Contributor Author

CI is still not passing. It seems to be a regression / behavior change with docker, so unsure what we can do in our code to fix this. Have checked prealpha-dev and it is failing as well. Will merge regardless.

@dOrgJelli dOrgJelli merged commit 34c4ded into prealpha-dev Dec 2, 2021
@dOrgJelli dOrgJelli deleted the issue-561-linkerror branch October 20, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krisbitney krisbitney krisbitney left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dOrgJelli @krisbitney