Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI Resolver Terminology Updates #806

Conversation

dOrgJelli
Copy link
Contributor

@dOrgJelli dOrgJelli commented Apr 8, 2022

Major Changes:

Old New
function getResolvers function getUriResolvers
const resolvers const uriResolvers
class UriToApiResolver class UriResolver
class ApiAggregatorResolver class ExtendableUriResolver
class ApiResolver class UriResolverWrapper

The above changes help make onboarding of these concepts more clear to new developers, since they are a bit more specific and descriptive.

@dOrgJelli dOrgJelli changed the title URI Resolver Vocabulary Updates URI Resolver Terminology Updates Apr 8, 2022
@nerfZael
Copy link
Contributor

nerfZael commented Apr 8, 2022

Major Changes:

Old New
function getResolvers function getUriResolvers
const resolvers const uriResolvers
class UriToApiResolver class UriResolver
class ApiAggregatorResolver class ExtendableUriResolver
class ApiResolver class UriResolverImplementation
The above changes help make onboarding of these concepts more clear to new developers, since they are a bit more specific and descriptive.

First three look great.

  • UriResolverImplementation: technically a class inheriting the UriResolver interface is an UriResolverImplementation
  • ExtendableUriResolver: I'm 50/50 on this

But, either way I think this is an improvement. So, unless there's some more ideas, I'm fine with merging this

@dOrgJelli
Copy link
Contributor Author

Discussed with Jure today, going to merge as we came to some great understandings.

@dOrgJelli dOrgJelli merged commit ff10d32 into nerfzael-uri-resolution-infinite-recursion Apr 9, 2022
@dOrgJelli dOrgJelli deleted the dorgjelli-uri-resolution-infinite-recursion branch February 2, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants