feat: use commander as arg-parser #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into commander-refactor
Niraj-Kamdar
commented
May 19, 2022
| `-e, --ens [<${intlMsg.commands_codegen_options_e_address()}>]`, | ||
| `${intlMsg.commands_codegen_options_e()}` | ||
| ) | ||
| .action(async (options) => { |
There was a problem hiding this comment.
This manual parsing isn't needed but it seems like there is some issue with commander parser handler so until it gets fixed, we will be using manual parsing.
nerfZael
requested changes
May 23, 2022
|
Do we still need gluegun, or could we completely remove it? |
Yep but it would be better to do it in other PR. |
dOrgJelli
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: CLI-V1: Refactor, Use Commader (Remove GlueGun) #748
Blocked by: Custom ensName fix for
buildAndDeployApi#861