Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wasm/rust Dockerfile #988

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Update wasm/rust Dockerfile #988

merged 1 commit into from
Jun 28, 2022

Conversation

dOrgJelli
Copy link
Contributor

@dOrgJelli dOrgJelli commented Jun 28, 2022 •
edited
Loading

Updates include:

  • Adding commonly used system dependencies: clang, llvm, build-essentials
  • Added steps to remove any wasm-bindgen imports that may have been injected (more details here)
  • Created a more consistent crate naming convention, so that artifacts in the target folder are consistent.

@dOrgJelli dOrgJelli requested a review from namesty as a code owner June 28, 2022 17:38
@dOrgJelli dOrgJelli merged commit 9e63628 into prealpha-dev Jun 28, 2022
@dOrgJelli dOrgJelli mentioned this pull request Jun 30, 2022
Merged
@dOrgJelli dOrgJelli mentioned this pull request Nov 15, 2022
Closed
@dOrgJelli dOrgJelli deleted the update-wasm-rs-dockerfile branch April 10, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namesty namesty Awaiting requested review from namesty namesty is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dOrgJelli