expand client cert search capabilities #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the --client-cert-issuer-cn option with a new set of options: --client-cert-from-store enables searching the OS cert store --client-cert-issuer selects between multiple available certificates based on an attribute of the cert's Issuer name --client-cert-subject selects between multiple available certificates based on an attribute of the cert's Subject name If only the first option is set, the cert store will be searched based on any CA names provided in the TLS Certificate Request message. Set a finalizer on the Windows credential type to release OS resources automatically. (The macOS credential type already does this.)
calebdoxsey
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace the
--client-cert-issuer-cnoption with a new set of options:--client-cert-from-storeenables searching the OS cert store overall--client-cert-issuerselects between multiple available certificates based on an attribute of the cert's Issuer name (e.g."CN=Trusted CA Name")--client-cert-subjectselects between multiple available certificates based on an attribute of the cert's Subject name (e.g."OU=Organization Unit Name"If only the first option is set, the cert store will be searched based on any CA names provided in the TLS Certificate Request message. This will be sufficient for devices with only a single matching certificate. (Note that this does requires Pomerium v0.23 or later, as v0.22 and earlier do not advertise trusted CA names in the TLS handshake.)
Also set a finalizer on the Windows credential type to release OS resources automatically. (The macOS credential type already does this.)
Related issues
Checklist
improvement/bug/ etc)