-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for wildcard / catch-all host #941
Comments
We should probably support leaving an empty host value, to allow routing all traffic through that ingress rule, as defined in the spec: https://github.com/kubernetes/api/blob/master/networking/v1/types.go#L397-L399
However, a host value of '*' is disallowed (but the behavior you are looking for is covered by the empty-host case anyway): https://github.com/kubernetes/api/blob/master/networking/v1/types.go#L401-L405
|
This adds support for empty host values in ingress rules, which act as wildcards and will match any hostname. A special annotation is required to enable this feature, so as to prevent unexpected behavior if the host name is unintentionally omitted.
This adds support for empty host values in ingress rules, which act as wildcards and will match any hostname. A special annotation is required to enable this feature, so as to prevent unexpected behavior if the host name is unintentionally omitted.
This adds support for empty host values in ingress rules, which act as wildcards and will match any hostname. A special annotation is required to enable this feature, so as to prevent unexpected behavior if the host name is unintentionally omitted.
* Support for empty host in ingress rules (#941) This adds support for empty host values in ingress rules, which act as wildcards and will match any hostname. A special annotation is required to enable this feature, so as to prevent unexpected behavior if the host name is unintentionally omitted. * Code cleanup/lint fixes
What happened?
Not writing any
host
in theIngress
resource results intopomerium
not accepting theIngress
because:What did you expect to happen?
Ingress specification allows to avoid specifying the
host
field, since it's optional.Since Pomerium supports wildcard (pomerium/pomerium#4131) the ingress controller should be able to map the absence of the
host
field to a*
host.It cannot be manually done because the
host
insideIngress
, if provided, must conform to a regex that do not allow to use just*
:\*\.[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*
How'd it happen?
Create a simple Ingress with no host:
What's your environment like?
pomerium --version
): v0.25.1What's your config.yaml?
The text was updated successfully, but these errors were encountered: