pomerium: Fix Enpoints port mapping #1102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test more combinations of named and numbered ports, and in particular avoid tests that happen to use the same name for the `port` and `targetPort`, as they could pass despite the implementation being broken. Signed-off-by: Benoît Knecht <bknecht@protonmail.ch>
When trying to determine which Endpoints port to use based on a named Service port, we weren't finding the right one when the Service `spec.ports[].name` didn't match the Service `spec.ports[].targetPort` name. This commit simplifies the mapping logic, and ensure the extended test from the previous commit all succeed. Signed-off-by: Benoît Knecht <bknecht@protonmail.ch>
BenoitKnecht
force-pushed
the
service-to-endpoints-mapping
branch
from
f0ff23e to
beefbbc
Compare
wasaga
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When trying to determine which Endpoints port to use based on a named
Service port, we weren't finding the right one when the Service
spec.ports[].namedidn't match the Servicespec.ports[].targetPortname.
This commit simplifies the mapping logic, and ensure the extended test
from the previous commit all succeed.
Here's an example of a Service and its associated Endpoints:
An Ingress refers to the Service by name, and to a specific port either by
name or by number.
If by name (
grafanain the example above), then it's always the same asthe port name on the Endpoints.
But if by number (
80in the example above), then we need to find thecorrect Endpoints port by matching the Service targetPort.
Checklist
improvement/bug/ etc)