Bump docker/build-push-action from 3.3.0 to 4.0.0 #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3.3.0 to 4.0.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@37abced...3b5e802) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
requested review from
calebdoxsey
and removed request for
a team
dependabot
bot
added
dependencies
calebdoxsey
approved these changes
Feb 6, 2023
calebdoxsey
deleted the
dependabot/github_actions/docker/build-push-action-4.0.0
branch
kenjenkins
added a commit
that referenced
this pull request
Oct 27, 2023
The current release workflow has recently been timing out, apparently
during the arm64 'generate' make target.
This workflow builds the controller inside Docker, for both linux/amd64
and linux/arm64. The arm64 build is emulated using QEMU, and based on
the logs from previous workflow runs, it may be up to 10x slower than
the amd64 build:
amd64 arm64
#519 81.5s 852.2s
#518 177.7s 1545.9s
#517 80.2s 853.7s
#516 79.5s 848.1s
(elapsed time of the 'RUN CGO_ENABLED=0 make build-go' step)
However, I don't think we actually need to run the entire build process
under emulation. We don't appear to use cgo, so I think it should be
equivalent to build on the host with GOARCH=arm64, and reduce the Docker
build step to just copying the resulting binary into the base image.
Also, it looks like the 'generate' target isn't needed except when
running the tests, so I think we can skip that bit entirely.
kenjenkins
added a commit
that referenced
this pull request
Oct 27, 2023
The current release workflow has recently been timing out, apparently
during the arm64 'generate' make target.
This workflow builds the controller inside Docker, for both linux/amd64
and linux/arm64. The arm64 build is emulated using QEMU, and based on
the logs from previous workflow runs, it may be up to 10x slower than
the amd64 build:
amd64 arm64
#519 81.5s 852.2s
#518 177.7s 1545.9s
#517 80.2s 853.7s
#516 79.5s 848.1s
(elapsed time of the 'RUN CGO_ENABLED=0 make build-go' step)
However, I don't think we actually need to run the entire build process
under emulation. We don't appear to use cgo, so I think it should be
equivalent to build on the host with GOARCH=arm64, and reduce the Docker
build step to just copying the resulting binary into the base image.
Also, it looks like the 'generate' target isn't needed except when
running the tests, so I think we can skip that bit entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps docker/build-push-action from 3.3.0 to 4.0.0.
Release notes
Sourced from docker/build-push-action's releases.
Commits
3b5e802Merge pull request #784 from crazy-max/enable-provenance02d3266update generated contentf403dafrevert disable provenance by default if not set1104d47Merge pull request #781 from crazy-max/disable-provenance838bf90update generated content337a09ddisable provenance by default if not setDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)