Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ingress/ci: use get-envoy cmd #988

Merged
merged 2 commits into from
Jun 28, 2024
Merged

ingress/ci: use get-envoy cmd #988

merged 2 commits into from
Jun 28, 2024

Conversation

calebdoxsey
Copy link
Contributor

@calebdoxsey calebdoxsey commented Jun 27, 2024 •
edited
Loading

Summary

Use the get-envoy command from core to replace the get-envoy script.

Related issues

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added the ci CI/CD and release automation label Jun 27, 2024
@calebdoxsey calebdoxsey marked this pull request as ready for review June 27, 2024 18:55
@calebdoxsey calebdoxsey requested a review from a team as a code owner June 27, 2024 18:55
@calebdoxsey calebdoxsey requested review from kenjenkins and removed request for a team June 27, 2024 18:55
@kralicky
Copy link
Contributor

Might want to merge #986 first

@kenjenkins
Copy link
Contributor

Could we merge #987 first for ease of backport?

@calebdoxsey calebdoxsey merged commit b1ea03e into main Jun 28, 2024
7 checks passed
@calebdoxsey calebdoxsey deleted the cdoxsey/get-envoy branch June 28, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kralicky kralicky kralicky approved these changes

@kenjenkins kenjenkins Awaiting requested review from kenjenkins kenjenkins is a code owner automatically assigned from pomerium/dev-backend

Assignees
No one assigned
Labels
ci CI/CD and release automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calebdoxsey @kralicky @kenjenkins