Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more route options #36

Merged
merged 3 commits into from
Feb 4, 2025
Merged

add more route options #36

merged 3 commits into from
Feb 4, 2025

Conversation

wasaga
Copy link
Collaborator

@wasaga wasaga commented Jan 31, 2025 •
edited
Loading

Adds more route options (still not exhaustive, others are coming as separate PR).

Related: https://linear.app/pomerium/issue/ENG-1761/routesresource-expose-all-fields

@wasaga wasaga requested a review from a team as a code owner January 31, 2025 20:41
@wasaga wasaga requested a review from calebdoxsey January 31, 2025 20:41
@wasaga wasaga marked this pull request as draft January 31, 2025 21:05
@wasaga wasaga changed the title add more route options wip: add more route options Jan 31, 2025
@wasaga wasaga marked this pull request as ready for review January 31, 2025 21:09
@calebdoxsey
Copy link
Contributor

Does route_data_source.go need to be updated too?

@wasaga wasaga changed the title wip: add more route options add more route options Feb 4, 2025
@wasaga wasaga merged commit 925616f into main Feb 4, 2025
3 checks passed
@wasaga wasaga deleted the wasaga/add-more-route-props branch February 4, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebdoxsey calebdoxsey calebdoxsey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wasaga @calebdoxsey