Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix web support by adding !kIsWeb check to Platform check #549

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

Oliver-Zimmerman
Copy link
Contributor

@Oliver-Zimmerman Oliver-Zimmerman commented Feb 10, 2025

There is a current issue here:
#547

This fixes it.

    if (backgroundColor == null && !kIsWeb && Platform.isIOS) {
      backgroundColor = Colors.black;
    }
    if (textColor == null && !kIsWeb && Platform.isIOS) {
      textColor = Colors.white;
    }

The !kIsWeb check ensures that the Platform.isIOS check is only executed on mobile devices and not on the web platform. This prevents a crash that would occur if Platform.isIOS is called on the web.

@Oliver-Zimmerman
Copy link
Contributor Author

@ponnamkarthik it would be great if you could include this in the next release. Web platform is currently broken

@ponnamkarthik ponnamkarthik merged commit 0edb4c7 into ponnamkarthik:master Feb 11, 2025
1 check passed
@ponnamkarthik
Copy link
Owner

Pushed new version try 8.2.12

Thanks for the PR @Oliver-Zimmerman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants