Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Ponytest color output in CMD and Powershell #2700

Closed
Shorttail opened this issue May 16, 2018 · 2 comments
Closed

Allow Ponytest color output in CMD and Powershell #2700

Shorttail opened this issue May 16, 2018 · 2 comments
Assignees
@chalcolith

Comments

@Shorttail
Copy link

Successful and failed tests come with green and red color ANSI color codes. These show up like �[92m in CMD and Powershell. I don't know if CMD and Powershell support the same or different color systems, but Git for Windows is able to display colors in both terminals.
@Shorttail
Copy link
Author

Shorttail commented May 16, 2018 •
edited
Loading

Creating a registry entry in HKEY_CURRENT_USER\Console named VirtualTerminalLevel of type DWORD with the value 1 enables ANSI escape codes in both CMD and Powershell. The fix requires only restarting the console.

@jemc
Copy link
Member

jemc commented May 18, 2018

According to strmpnk on IRC, there is also an FFI call that Pony could/should do on Windows to enable ANSI escape codes without changing the registry: https://docs.microsoft.com/en-us/windows/console/setconsolemode

chalcolith added a commit to chalcolith/ponyc that referenced this issue May 18, 2018
@chalcolith
Enable virtual terminal color output on Windows.
0fc0a70 
This enables support for ANSI escape sequences in Windows console output for `stdout` and `stderr` for all Pony programs.

  Fixes ponylang#2700.

Note that this will only work on Windows 10 builds later than 10586.
@chalcolith chalcolith mentioned this issue May 18, 2018
Merged
@chalcolith chalcolith self-assigned this May 18, 2018
chalcolith added a commit that referenced this issue May 18, 2018
@chalcolith
Enable virtual terminal color output on Windows. (#2702)
c5c4607 
This enables support for ANSI escape sequences in Windows console output for `stdout` and `stderr` for all Pony programs.

  Fixes #2700.

Note that this will only work on Windows 10 builds later than 10586.
dipinhora pushed a commit to dipinhora/ponyc that referenced this issue Jun 5, 2018
@chalcolith @dipinhora
Enable virtual terminal color output on Windows. (ponylang#2702)
8ed7090 
This enables support for ANSI escape sequences in Windows console output for `stdout` and `stderr` for all Pony programs.

  Fixes ponylang#2700.

Note that this will only work on Windows 10 builds later than 10586.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chalcolith chalcolith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chalcolith @Shorttail @jemc