Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compiler segmentation fault when given an invalid target triple. #1406

Merged
merged 1 commit into from
Nov 9, 2016

Conversation

Praetonus
Copy link
Member

No description provided.

Copy link
Member

@jemc jemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a significant user-visible fix to need a changelog, or is it good to go when CI passes (or were you wanting to use the automated changelog system)?

@Praetonus
Copy link
Member Author

@jemc It fixes a segfault if the user supplies an invalid target triple, so a changelog entry would be good. The automated system should be fine, and I'll add some details in the commit message.

This change fixes a segmentation fault when an invalid target triple is
supplied.
@jemc jemc added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Nov 9, 2016
@jemc jemc changed the title Do not ignore LLVM target creation errors Fixed compiler segmentation fault when given an invalid target triple. Nov 9, 2016
@jemc jemc merged commit a9fc0de into ponylang:master Nov 9, 2016
ponylang-main added a commit that referenced this pull request Nov 9, 2016
@Praetonus Praetonus deleted the triple-error branch November 9, 2016 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants