Reify function references used as addressof operands correctly #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a function reference used as the operand of `addressof` was only reified in `expr_qualify`. Since this function is only called when there is at least one type argument, a function referenced with no type arguments wouldn't be checked. This change fixes the issue by reifying the function in `expr_addressof` if the function reference wasn't already reified.
jemc
added
the
changelog - fixed
ponylang-main
added a commit
that referenced
this pull request
Apr 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a function reference used as the operand of
addressofwas only reified inexpr_qualify. Since this function is only called when there is at least one type argument, a function referenced with no type arguments wouldn't be checked. This change fixes the issue by reifying the function inexpr_addressofif the function reference wasn't already reified.