Don’t consider type arguments inside a constraint as constraints. #1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This better reflects their use. It allows arrow types and tuples to appear in these positions. It also denies capability sets from appearing in these positions. These have an extremely limited use, and are unlikely to be used by anyone. As a side effect, the default capability in these positions now corresponds to the type default, rather than #any. Also properly deny arrow types from appearing in constraints, fixing ponylang#1809.
plietar
force-pushed
the
fix-nested-constraints
branch
from
8eb3a8c to
3333e6d
Compare
jemc
added
the
changelog - fixed
|
Thanks!
I agree - I don't think any of the existing test files are a good fit. Probably the best bet would be to create a new test file called However, since this is already a complete fix for the other bugs you noticed, I'll go ahead and merge this PR. You can feel free to add the positive tests in another PR if you wish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This better reflects their use. It allows arrow types and tuples to
appear in these positions. It also denies capability sets from appearing
in these positions. These have an extremely limited use, and are unlikely
to be used by anyone.
As a side effect, the default capability in these positions now
corresponds to the type default, rather than #any.
Also properly deny arrow types from appearing in constraints,
fixing #1809.
I'd like to add some positive tests for arrows and tuples in these positions,
but I'm not sure where they fit.