Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit internal methods to library headers #1890

Merged
merged 1 commit into from
May 5, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ All notable changes to the Pony compiler and standard library will be documented
- Compiler error instead of crash for invalid this-dot reference in a trait. ([PR #1879](https://github.com/ponylang/ponyc/pull/1879))
- Compiler error instead of crash for too few args to constructor in case pattern. ([PR #1880](https://github.com/ponylang/ponyc/pull/1880))
- Pony runtime hashmap bug that resulted in issues [#1483](https://github.com/ponylang/ponyc/issues/1483), [#1781](https://github.com/ponylang/ponyc/issues/1781), and [#1872](https://github.com/ponylang/ponyc/issues/1872). ([PR #1886](https://github.com/ponylang/ponyc/pull/1886))
- Compiler crash when compiling to a library (issue #1881)


### Added

Expand Down
8 changes: 6 additions & 2 deletions src/libponyc/codegen/genheader.c
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,12 @@ static void print_params(compile_t* c, printbuf_t* buf, ast_t* params)

static bool emit_fun(ast_t* fun)
{
// No signature for any function with a tuple argument or return value, or
// any function that might raise an error.
// No signature for any internal function (i.e. functions without an AST), or
// any function with a tuple argument or return value, or any function that
// might raise an error.
if(fun == NULL)
return false;

AST_GET_CHILDREN(fun, cap, id, typeparams, params, result, can_error);

if(ast_id(can_error) == TK_QUESTION)
Expand Down