Prevent duplicate long_tests from being registered #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it is possible to call `long_test` more than once for a given test. This results in more than 1 timer being registered, however, we only keep track of 1 of timers registered so when the test is completed, all timers are not cancelled and tests will continue "to run" until the timer finishes. This PR prevents duplicate long tests from being registered by only setting up a long test if one hasn't already been registered. If one is already registered, we skip the normal setup procedure and log a warning.
|
I've managed to been bit by the problem more than once. I doubt I would be the only one. Today it took me 45 minutes to track down the problem. I think this small change will save folks a ton of time. |
SeanTAllen
added
the
changelog - fixed
jemc
approved these changes
Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is possible to call
long_testmore than once for a giventest. This results in more than 1 timer being registered, however, we
only keep track of 1 of timers registered so when the test is completed,
all timers are not cancelled and tests will continue "to run" until the
timer finishes.
This PR prevents duplicate long tests from being registered by only
setting up a long test if one hasn't already been registered. If one is
already registered, we skip the normal setup procedure and log a
warning.