Add minimal-case/issue-2451

[winksaville]

Adds test-long-term Makefile target for testing.

[jemc]

I don't think this target will work in isolation - you should add the bit that builds the stdlib binary to this small Makefile.

[winksaville]

At the moment I don't want to duplicate code in the main Makefile. The user may want to compile in various ways that I'm not sure of, for instance it's been recommended to compile ponyc in debug mode and I certainly don't want to prematurely assume anything. So for now I'd like to keep it simple.

…

On Fri, Dec 29, 2017, 4:47 PM Joe Eli McIlvain ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In minimal-cases/issue-2451/Makefile <#2458 (comment)>: > @@ -0,0 +1,10 @@ +# For a long term test build stdlib-debug or stdlib +# using the standard Makefile and then run test-long-term +# to ./stdlib --sequential in a loop with logs captured +# in stdlib-ymd-hms.ns.txt. +test-long-term: + while true; do echo "Date: `date +%y%m%d-%H%M%S.%N`"; ./stdlib --sequential; echo "stdlib done"; done 2>&1 | tee stdlib-`date +%y%m%d-%H%M%S.%N`.txt I don't think this target will work in isolation - you should add the bit that builds the stdlib binary to this small Makefile. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2458 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA-hHLq0pRNClXQrivLIPoh0mnNU6j8nks5tFYgUgaJpZM4RPb5Q> .

[SeanTAllen]

Can this be closed?

[winksaville]

I'd like this merged so it's available for use when testing. We can delete it after resolving #2451. And I hope to find a simpler test to reproduce the issues.

[SeanTAllen]

I dont think this requires a makefile change. It could be done without any change to the Makefile. The command the makefile runs in that target can be added to the minimal case example directly.

[winksaville]

Yes, but we don't have a minimal example yet, only stdlib. I could duplicate stdlib, but that doesn't seem prudent.

…

On Thu, Jan 4, 2018, 6:23 AM Sean T Allen ***@***.***> wrote: I dont think this requires a makefile change. It could be done without any change to the Makefile. The command the makefile runs in that target can be added to the minimal case example directly. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2458 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA-hHF8W5dM-Fg8lc1hWFtRt9o1YUKsQks5tHN7YgaJpZM4RPb5Q> .

[SeanTAllen]

Sorry, I thought that was in the standard Makefile. Nevermind.

[SeanTAllen]

@jemc this look good to you?

[jemc]

I'd like to see this example refactored to invoke the outer Makefile to build the stdlib executable. That way, the example works with no other steps than just running it, and still doesn't have to duplicate logic from the root Makefile.

[winksaville]

The default all target now targets make-stdlib and then test-long-term.

[winksaville]

I think we're getting close to a resolution so closing, will reopen if the need arises.