Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FilePath.walk performance issues (issue #2158). #2634

Merged
merged 1 commit into from
Apr 5, 2018
Merged

Fix FilePath.walk performance issues (issue #2158). #2634

merged 1 commit into from
Apr 5, 2018

Conversation

ikavalio
Copy link
Contributor

@ikavalio ikavalio commented Apr 5, 2018

Hi, this PR fixes 2 issues mentioned in #2158:

  • directory is disposed in the end of the loop, otherwise it can result in too many open files error.
  • files are omitted from recursive descend, so Directory(this)? should work without throwing so many errors.

jemc
jemc approved these changes Apr 5, 2018
View reviewed changes
Copy link
Member

@jemc jemc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'll leave some time for others to chime in (and for the CI to finish) before merging.

@SeanTAllen
Copy link
Member

Seems good.

@jemc jemc changed the title Refactoring FilePath.walk method (Issue #2158) Fix FilePath.walk performance issues (issue #2158). Apr 5, 2018
@jemc jemc added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Apr 5, 2018
@jemc jemc merged commit 09c30ec into ponylang:master Apr 5, 2018
@jemc
Copy link
Member

jemc commented Apr 5, 2018

Great work, @ikavalio - thanks for your contribution!

ponylang-main added a commit that referenced this pull request Apr 5, 2018
@ponylang-main
Update CHANGELOG for PR #2634 [skip ci]
b154f12
@jemc jemc mentioned this pull request Apr 5, 2018
Closed
@ikavalio ikavalio deleted the issue-2158 branch April 6, 2018 09:06
dipinhora pushed a commit to dipinhora/ponyc that referenced this pull request Jun 5, 2018
@ikavalio @dipinhora
refactor file_path walk method (ponylang#2634)
5c3607d 
Fix FilePath.walk performance issues (issue ponylang#2158).
dipinhora pushed a commit to dipinhora/ponyc that referenced this pull request Jun 5, 2018
@ponylang-main @dipinhora
Update CHANGELOG for PR ponylang#2634 [skip ci]
f4678f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemc jemc jemc approved these changes

Assignees
No one assigned
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikavalio @SeanTAllen @jemc